Anastasia Klimchuk submitted this change.

View Change

Approvals: Aarya: Looks good to me, approved build bot (Jenkins): Verified
flash: Update the comment for flashchip eraseblocks

Change-Id: Ica7790667ac4c1baf961cb7a330e08178e2c0c28
Signed-off-by: Anastasia Klimchuk <aklm@chromium.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/75744
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aarya <aarya.chaumal@gmail.com>
---
M include/flash.h
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/include/flash.h b/include/flash.h
index 0eace15..4c08549 100644
--- a/include/flash.h
+++ b/include/flash.h
@@ -449,9 +449,7 @@
/*
* Erase blocks and associated erase function. Any chip erase function
* is stored as chip-sized virtual block together with said function.
- * The first one that fits will be chosen. There is currently no way to
- * influence that behaviour. For testing just comment out the other
- * elements or set the function pointer to NULL.
+ * The logic for how to optimally select erase functions is in erasure_layout.c
*/
struct block_eraser {
struct eraseblock {

To view, visit change 75744. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ica7790667ac4c1baf961cb7a330e08178e2c0c28
Gerrit-Change-Number: 75744
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Aarya <aarya.chaumal@gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged