Attention is currently required from: Angel Pons, Anastasia Klimchuk.
Patch set 1:Code-Review +2
View Change
1 comment:
File jlink_spi.c:
Patch Set #1, Line 181: init_ret
just call this ret and default to failure, that is to say initialise with 1 instead of 0.
This will save you some lines but also cause success to be explicit rather than failure which seems safer.
To view, visit change 52308. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I71f64ed38154af670d4d28b8c7914d87fbc75679
Gerrit-Change-Number: 52308
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Nikolai Artemiev <nartemiev@google.com>
Gerrit-CC: Sam McNally <sammc@google.com>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Comment-Date: Thu, 15 Apr 2021 02:36:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment