Attention is currently required from: Nico Huber, Diana Zigterman, Jon Murphy, Edward O'Callaghan, Anastasia Klimchuk, Karthik Ramasubramanian.

View Change

2 comments:

• File raiden_debug_spi.c:

  • Patch Set #2, Line 989: if (rsp_config.packet_size == 4 &&

    is packet size in bytes or words? Can we use sizeof() instead of a magic number? Can you update th […]

    Done

  • Patch Set #2, Line 1002: return status;

    Is it always wrong to retry in this case? The commit message only argues […]

    You're correct, one of the error codes is actually a busy indicator. I've updated the code to only handle the `USB_SPI_DISABLED` case and let it fall back to the current behavior for other errors.

To view, visit change 62909. To unsubscribe, or for help writing mail filters, visit settings.