Felix Singer submitted this change.

View Change


Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved
manibuilder: Maintain list of broken images

Disable images that can't be built anymore by default. We keep them
listed, so existing images can still be used. Also add commands to
show and run all supposed-to-be working tags.

Change-Id: I0f0ffb6c5e28348656aac2ce265f8b1dc0e93362
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/66996
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Felix Singer <felixsinger@posteo.net>
---
M util/manibuilder/Makefile.targets
1 file changed, 29 insertions(+), 0 deletions(-)

diff --git a/util/manibuilder/Makefile.targets b/util/manibuilder/Makefile.targets
index ec4bdfa..dff3879 100644
--- a/util/manibuilder/Makefile.targets
+++ b/util/manibuilder/Makefile.targets
@@ -38,6 +38,12 @@

ALL_TAGS := $(ANITA_TAGS) $(MULTIARCH_TAGS) $(OTHER_TAGS)

+BROKEN_TAGS := anita\:7.1-amd64 anita\:7.1-i386 \
+ centos\:7.6-armhfp-clean \
+ fedora\:30-s390x fedora\:28-armhfp \
+
+WORKING_TAGS := $(filter-out $(BROKEN_TAGS),$(ALL_TAGS))
+
arch_filter = $(sort \
$(foreach arch,$(1), \
$(filter-out $(subst $(arch),,$(MULTIARCH_TAGS)),$(MULTIARCH_TAGS))))
@@ -184,6 +190,8 @@

native: $(NATIVE_TAGS)

+working: $(WORKING_TAGS)
+
all: $(ALL_TAGS)

1.0.x: export TEST_REVISION=refs/heads/1.0.x
@@ -198,6 +206,9 @@
show-native:
@printf "%s\n" $(NATIVE_TAGS)

+show-working:
+ @printf "%s\n" $(WORKING_TAGS)
+
show-all:
@printf "%s\n" $(ALL_TAGS)


To view, visit change 66996. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0f0ffb6c5e28348656aac2ce265f8b1dc0e93362
Gerrit-Change-Number: 66996
Gerrit-PatchSet: 4
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged