Attention is currently required from: Edward O'Callaghan, Angel Pons.
View Change
1 comment:
Commit Message:
Patch Set #4, Line 12: closer to cli_classic as a pure libflashrom user.
It does, but kind of by moving CLI code into libflashrom. do_erase()
is practically CLI code, it's just in the wrong file. Also, adding a
FIXME to libflashrom doesn't look like progress. I guess the FIXME
is the reason that the call is in CLI code. How about we just move it
into `cli_classic.c`?
To view, visit change 60068. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8566164e7dbad69cf478b24208014f10fb99e4d0
Gerrit-Change-Number: 60068
Gerrit-PatchSet: 4
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Daniel Campello <campello@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-CC: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Thu, 20 Jan 2022 23:50:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment