Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Sergii Dmytruk.

View Change

1 comment:

• File ichspi.c:

  • Patch Set #2, Line 1413:

    static bool ich_hwseq_can_read_register(const struct flashctx *flash, enum flash_reg reg)
    {
    	return reg == STATUS1;
    }
    
    static bool ich_hwseq_can_write_register(const struct flashctx *flash, enum flash_reg reg)
    {
    	return reg == STATUS1;
    }
    

    Possibly the programmer fills a instance of `struct reg_bit_info` and the writeprotect implementatio […]

    It might be better to use functions instead of structs, given the many-to-one relationship between devices and drivers. I.e. we could have multiple devices with different register access capabilities that use the same driver.

    This doesn't apply to the ich hwseq master afaik, but it could if we need to use this abstraction for another programmer.

To view, visit change 66032. To unsubscribe, or for help writing mail filters, visit settings.