Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.

View Change

6 comments:

• Commit Message:

  • Patch Set #3, Line 7: tests: Make chip definitions static global

    The summary line should somehow cover all the changes. If you
    do much in a single commit, it might simply end up as a vague
    "tests: Revise chip definitions".

  • Patch Set #3, Line 13: was confusing. Mock chip looks more realistic now.

    Generally, moving and changing code in a single commit often
    makes the review unnecessarily harder. Not too bad in this case.

• File tests/chip.c:

  • Patch Set #3, Line 24: CHIP_TOTAL_SIZE

    There's another chip below with a different size. Should we name it
    `MOCKED_CHIP_SIZE` maybe?

  • Patch Set #3, Line 24: #define CHIP_TOTAL_SIZE 8388608

    Please make use of the KiB/MiB macros. This should be `(8*MiB)` (usually
    written without spaces around the asterisk).

  • Patch Set #3, Line 128: static struct flashchip chip_8MiB = {

    Should we make them `const` and then work on a copy on the stack?
    That way we'd have a fresh copy for every test.

  • Patch Set #3, Line 130: .total_size = 8 * 1024,

    CHIP_TOTAL_SIZE / KiB

To view, visit change 57437. To unsubscribe, or for help writing mail filters, visit settings.