Attention is currently required from: Stefan Reinauer, Edward O'Callaghan, Angel Pons.

View Change

4 comments:

• File bitbang_spi.c:

  • Patch Set #14, Line 74: bitbang_spi_set_sck_set_mosi

    Where did this go?

    read operate don't care mosi. The previous code is problematic.

  • Patch Set #14, Line 53: master->set_sck(val);

    For sanity's sake, only use `cpol` here.

    This obscures the meaning

  • Patch Set #14, Line 68: bitbang_spi_set_sck_set_mosi

    If you're reordering the operations inside this function, I would also rename everything accordingly […]

    https://review.coreboot.org/c/flashrom/+/49264

  • Patch Set #14, Line 210: ERROR_FLASHROM_BUG

    Definitely not a flashrom bug.

    I am not very clear, the previous code used this to put back the value

To view, visit change 49255. To unsubscribe, or for help writing mail filters, visit settings.