Patch set 7:Code-Review +2
View Change
1 comment:
File flashchips.c:
Patch Set #6, Line 17435: /* We present our own "report this" text hence we do not */
I think we want multi-line comments to be of the following style:
```
/**
* xxx
*/
```
However in the interest of unifying flashchips.c with Chromium's version and getting a lot more chip support we can do this for the moment.
To view, visit change 33834. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8708a11993822085b3e8d8c80532dfb935d39876
Gerrit-Change-Number: 33834
Gerrit-PatchSet: 7
Gerrit-Owner: Alan Green <avg@google.com>
Gerrit-Reviewer: Alan Green <avg@google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Tue, 02 Jul 2019 03:44:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment