Attention is currently required from: Krystian Hebel, Maciej Pijanowski, Michał Kopeć, Michał Żygowski, Sergii Dmytruk.

View Change

3 comments:

• Commit Message:

  • Patch Set #5, Line 10:

    
    The IDs of IoT chipset SKUs (ending with E) can only be found in "12th Gen Intel® Core™ Processors Family (Formerly Known as Alder Lake -S) for IoT Platforms External Design Specification (EDS) Addendum" DOC 634528 rev 2.7 (NDA).
    
    TEST=Probe flash on Z790 chipset. Run the ich_descriptors_tool and check output is correct as expected.
    

    Just one last thing: if you could wrap commit message by max width 72 chars, as we have by the style guide, thanks!
    https://flashrom.org/dev_guide/development_guide.html#commit-message-1

• File chipset_enable.c:

  • Patch Set #4, Line 2209:

    	{0x8086, 0x7a90, B_S,    NT,  "Intel", "R680E",				enable_flash_pch600},
    	{0x8086, 0x7a91, B_S,    NT,  "Intel", "Q670E",				enable_flash_pch600},
    	{0x8086, 0x7a92, B_S,    NT,  "Intel", "H610E",				enable_flash_pch600}
    

    Added info to the commit message

    Perfect, thank you

• File util/ich_descriptors_tool/ich_descriptors_tool.c:

  • Patch Set #3, Line 142: "\t- \"600\" or \"alder\" for Intel's 600 series chipsets.\n"

    Got it, added info to the commit message that ich_descriptors_tool has also been tested

    Done

To view, visit change 83854. To unsubscribe, or for help writing mail filters, visit settings.