Attention is currently required from: Aarya, Nikolai Artemiev, Sergii Dmytruk.
View Change
2 comments:
File flashrom.c:
Patch Set #5, Line 1235:
/* const size_t flash_size = flashctx->chip->total_size * 1024; */
/* const size_t page_size = flashctx->chip->page_size; */
I think I can remove these lines
Patch Set #5, Line 1958: init_progress(flashctx, FLASHROM_PROGRESS_READ, flash_size); // WTF?
What was your concern on this line? Was something not working? (see line comment)
To view, visit change 84102. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: If1e40fc97f443c4f0c0501cef11cff1f3f84c051
Gerrit-Change-Number: 84102
Gerrit-PatchSet: 5
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-Reviewer: Aarya <aarya.chaumal@gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Aarya <aarya.chaumal@gmail.com>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-Comment-Date: Sun, 29 Sep 2024 07:29:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No