Hi, welcome and thanks for sending this change!
Looks pretty good, just a minor suggestion about the commit summary (which you can easily address with the gerrit web interface).
Patch Set 1: Code-Review+1
I see that your one of the maintainer of flashrom, I request for a review for addition of this flash type.
Usually, giving code-review scores to one's own changes is discouraged (the idea is that others review and give a score to your change). But as this is your first change in gerrit, I understand it's just a rookie mistake, no big deal :)
Patch set 1:Code-Review +2
1 comment:
Patch Set #1, Line 7: add support to SPI flash MX25L51245G
I would suggest the following commit summary:
flashchips: Add Macronix MX25L51245G
(You can use the "Edit" button on the gerrit change's page, under the commit message)
To view, visit change 34234. To unsubscribe, or for help writing mail filters, visit settings.