Attention is currently required from: Nico Huber, Caveh Jalali, Tim Wawrzynczak, Edward O'Callaghan, Sridhar Siricilla, Angel Pons, Nick Vaccaro, Alex Levin, YH Lin, Boris Mittelberg.
View Change
1 comment:
File ichspi.c:
Patch Set #3, Line 1392: while
@Angel pons already pointed this! I'm closing the comment here.
@Sridhar, Rizwan suggested me this is what CSE also does, kind of blocking.
if you see my CLs in coreboot and DC, I have used the non-blocking call but with flashrom, don't want to take the risk because it will get consumed in multithreaded env
https://review.coreboot.org/c/coreboot/+/61849/4/src/soc/intel/common/block/fast_spi/fast_spi_flash.c#132
To view, visit change 61854. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib9265cc20513fd00f32f8fa22e28c312903ca484
Gerrit-Change-Number: 61854
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: Alex Levin <levinale@chromium.org>
Gerrit-Reviewer: Boris Mittelberg <bmbm@google.com>
Gerrit-Reviewer: Caveh Jalali <caveh@chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro@google.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi@intel.com>
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla@intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Caveh Jalali <caveh@chromium.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla@intel.com>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro@google.com>
Gerrit-Attention: Alex Levin <levinale@chromium.org>
Gerrit-Attention: YH Lin <yueherngl@chromium.org>
Gerrit-Attention: Boris Mittelberg <bmbm@google.com>
Gerrit-Comment-Date: Sat, 12 Feb 2022 04:34:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sridhar Siricilla <sridhar.siricilla@intel.com>
Gerrit-MessageType: comment