3 comments:

File flashrom.c:
- Patch Set #5, Line 1379:
  I could think of a future use that might be useful if/once fmap support is implemented: if you use a […]
  More specifically, to make sure that the include args for write operations don't overlap. For reading it should be fine.
File flashrom.c:
- Patch Set #7, Line 1380:
```
		if (!entry->included || !entry->file)
			continue;
```
  Optionally: […]
  Actually, I don't think we should check for entry->file here. Doing so will require that all included entries have a file specified which is not always desirable.
  The higher-level logic should check if an argument to -w was specified to decide what to do here:
  - If a file is specified for -w, then we do not need a file specified for each -i arg.
  - If a file is not specified for -w, then we need a file specified for each -i arg.
  Removing the check here will also obviate the need for my get_num_include_args_with_files() hack in PS11.
File layout.c:
- Patch Set #11, Line 174:
```
Use the -l/--layout parameter to specify\n"
			 "a layout file.
```
  We should probably clarify this comment or get rid of the latter half since the layout can come from a few different sources (layout file, IFD, and soon FMAP).

To view, visit change 23021. To unsubscribe, or for help writing mail filters, visit settings.