Attention is currently required from: Felix Singer, Thomas Heijligen, Anastasia Klimchuk, Alexander Goncharov.

Patch set 2:Code-Review +1

View Change

1 comment:

• Patchset:

  • Patch Set #1:

    I spent some time trying to understand this very eloquent conversation :D

    Thanks for putting in the effort! 😅

    I looked into alternative patch CB:66225 and I see that Felix pushed the latest patchset which makes it almost the same as this patch (that's probably what the first huh means). This patch, however has a comment, which I think is good, good to have a comment (that's probably the second huh).

    My "Huh?" simply means that I don't understand what Felix's "Huh?" means.

    So technically there are two options what to do:
    1) Click Submit for this patch, abandon CB:66225
    2) Felix uploads one more patchset to CB:66225, with a comment, which would make CB:66225 identical to this one. Then click submit on CB:66225 and abandon this one.

    Just from purely technical perspective 1) looks easier. If CB:66225 would be mine, I would just say yeah let's abandon. But it is not mine, started by another contributor, and yes it was pushed earlier.
    I vote for 1) and I can write a nice comment to CB:66225 explaining what has happened.
    What do other people think?

    I too vote for 1) as it seems more straightforward.

To view, visit change 67700. To unsubscribe, or for help writing mail filters, visit settings.