Patch Set 1:

So FCH is the compromise because it's somewhere between SB600 and
their SoCs? Or do they call part of the SoC FCH, too? I find it
rather confusing.

How about amdspi? or amd_spi?

If the two IP blocks are substantially different, I'd suggest having separate files. But if that is too overkill, I'd say fchspi.c is not really representative.

View Change

To view, visit change 36434. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iad92fb224954d66968e7aeb75cb515f075a26ac8
Gerrit-Change-Number: 36434
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan <>
Gerrit-Reviewer: build bot (Jenkins) <>
Gerrit-CC: Angel Pons <>
Gerrit-CC: Nico Huber <>
Gerrit-Comment-Date: Wed, 24 Jun 2020 16:19:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment