Attention is currently required from: Daniel Campello, Angel Pons.
1 comment:
Patchset:
Sorry for delay, just looked into this patch.
I was initially worried about such a change, because it looked like a hack to me. read_flash_to_file is used in many flows (not only extract operation). Allowing empty filename for all of them would be error-prone, like removing protection on a very low level.
However! There is another patch which makes a difference, CB:59291 (convert do_read() into a libflashrom user). If this fix would be based on the top of CB:59291 , it would look more like a solution and not a hack. It would not be a "removing protection on a very low level" that I am concerned about, since filename check would move from read_flash_to_file into do_read.
Daniel, if you can rebase this on the top of CB:59291 that would be great, thanks! You already reviewed CB:59291 and added a comment :)
To view, visit change 59921. To unsubscribe, or for help writing mail filters, visit settings.