View Change

1 comment:

• File it85spi.c:

  • Patch Set #11, Line 77: unsigned int shm_io_base;

    For 100% consistency with existing code, this should be: […]

    In existing code, wrapping this with ifdef-endif was needed, because otherwise compiler would produce a warning that shm_io_base is unused (it was not used on !LPC_IO code path). After shm_io_base becomes a member of a struct, compiler checks that struct is used (and it is), does not check individual members usage.
    The only reason to have ifdef-endif around shm_io_base was to avoid compiler warning, and since it is not an issue anymore - ifdef-endif not needed anymore here.

To view, visit change 47655. To unsubscribe, or for help writing mail filters, visit settings.