View Change

3 comments:

• File lspcon_i2c_spi.c:

  • Patch Set #4, Line 364: uint8_t write_buffer[len + 1];

    We can use a fixed size buffer with buf[256 + 1] since that'd be the max size. […]

    You could have a static buffer of len 257 /* extra byte needed for prefixing zero in idx 0 */
    and a if check to validate len does not exceed the static buffer before the memcpy()

  • Patch Set #4, Line 365: write_buffer[0] = 0

    Do you have any idea if we have to change this or resolve the comment?

    by initialising the static buf to zero you can skip this.

  • Patch Set #4, Line 366: write_buffer + 1

    just say &write_buf[1] here, kind of makes it more clear.

To view, visit change 39687. To unsubscribe, or for help writing mail filters, visit settings.