Attention is currently required from: Nikolai Artemiev, Sergii Dmytruk.

View Change

1 comment:

• Commit Message:

  • Patch Set #4, Line 10: preventing confusion

    I guess it depends on the meaning of `NT`. I took it as "unknown" which can also include `NA`. […]

    Wrt. if this prevents confusion, I don't think it matters how we define `NT`.
    What causes or prevents confusion is what we print, i.e. "WP operations are
    not implemented for this chip" vs. "this chip doesn't support WP". I'm not
    sure if that is enough.

    We would still print the former in the NT case, right? Which is the most
    common and most confusing state, IMHO. And if we'd change the text, how
    could we distinguish "unknown" from "known WP support but not implemented"?

    I'm not against this change, just not sure if it changes something (wrt. usability).

To view, visit change 68221. To unsubscribe, or for help writing mail filters, visit settings.