Attention is currently required from: Nico Huber, Angel Pons.

View Change

1 comment:

• Patchset:

  • Patch Set #1:

    As you can see from the amount of tests, it's a rather new topic for […]

    Thank you! I will try to address your other comment to create mocks in separate compilation unit. I am working on understanding how to do it. Good thing I need to do this hard thing once, and then just write more tests.

    Re: flashbuses_to_text_test_success() I agree. I am not touching it yet because it is an existing test. But ideally I would find what place is using those strings and test that place. In other words, what is going to fail if the string is different?

To view, visit change 51487. To unsubscribe, or for help writing mail filters, visit settings.