Attention is currently required from: David Hendricks, Edward O'Callaghan, Julius Werner, Angel Pons, Arthur Heymans.
View Change
1 comment:
Patchset:
Patch Set #1:
Yeah I noticed layout.h but I wasn't sure if it was okay to pull that into libflashrom. […]
It seems you are burdening yourself with too much knowledge :) I generally like
too keep things simple, in this case standard C. No need to care what choices OS's
make wrt. the size of `long`. All we need to know is that it can represent numbers
from -2^32 to 2^31-1.
Actually I'm not sure about flash chip sizes, 32Gbit doesn't seem too far away
anymore. Maybe we should aim higher right away? or risk an API change later?
To view, visit change 61943. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I68a386973f79ea634f63dfcd7d95a63400e1fdee
Gerrit-Change-Number: 61943
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: David Hendricks <david.hendricks@gmail.com>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Julius Werner <jwerner@chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Comment-Date: Wed, 16 Feb 2022 10:53:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Julius Werner <jwerner@chromium.org>
Gerrit-MessageType: comment