Attention is currently required from: Keith Hui, Light, Anastasia Klimchuk.

Patch set 4:Code-Review +1

View Change

1 comment:

• Patchset:

  • Patch Set #1:

    Maybe INB has some side-effects, for example doing something and then the assignment happens. […]

    `INB(0x80)` reads a byte from I/O port 0x80. This port is typically used to output POST codes, so the data being read is irrelevant. I'm pretty sure this is just to "relax" the polling loop a bit (make it poll less frequently).

    One would typically use a proper delay function instead. This is especially important when communicating with another microcontroller: querying the status could trigger an interrupt handler in the other microcontroller, and polling too often would unnecessarily slow things down. This doesn't matter in this case, as the status is provided by hardware.

    TL;DR: This is used as a very small delay, it could be replaced with a proper delay function but I'm not sure if it's worth it (Keith would know better).

To view, visit change 62761. To unsubscribe, or for help writing mail filters, visit settings.