Attention is currently required from: Nico Huber, Nikolai Artemiev, Sergii Dmytruk.

8 comments:

File flash.h:
- Patch Set #14, Line 169:
```
enum flash_reg {
	INVALID_REG = 0,
	STATUS1,
	STATUS2,
	CONFIG1,
};
#define MAX_REGISTERS 4
```
  Does this need to be public, or can it remain private inside `spi25_statusreg.c`?
File spi25_statusreg.c:
- Patch Set #14, Line 51: int result = spi_send_multicommand(flash, cmds);
  Would be good to check with manibuilder if this causes problems with unusual toolchains (e.g. DJGPP).
- Patch Set #14, Line 126:
  should be a tab
- Patch Set #14, Line 134:
  nit: double blank line
- Patch Set #14, Line 138: /* FIXME: We should propagate the error. */
  Ah, this is why you want to drop `spi_read_status_register()`
- Patch Set #14, Line 149:
  nit: double blank line
- Patch Set #14, Line 194: spi_write_register failed.
  Would be good to indicate which register failed:
```
 Could not write status register 1.
```
  Or similar.
- Patch Set #14, Line 207: spi_write_register failed.
  Ditto

To view, visit change 58475. To unsubscribe, or for help writing mail filters, visit settings.