david.hendricks@gmail.com posted comments on this change.

View Change

Patch set 1:

(4 comments)

• Commit Message:

  • Patch Set #1, Line 9:

    The max buffer size of the linux kernel's SPI device is a compile-time parameter.
    Read it on initialization and use it to inform the max transfer size. We allow
    up to 5 bytes for the SPI command. On master, SPI commands are always 4 bytes,
    but 4ba support will raise that to 5. Choosing 5 makes sure this will keep
    

    long lines

  • Patch Set #1, Line 12:

    but 4ba support will raise that to 5. Choosing 5 makes sure this will keep
    working when 4ba support is merged.
    

    4BA has been merged, so I updated the wording here.

• File linux_spi.c:

  • Patch Set #1, Line 138: atoi(buf);

    Updated to use strtol() and add some paranoid error checking.

  • Patch Set #1, Line 141:

    	if (param_fd != -1)
    		close(param_fd);
    

    May as well put this in the else clause above.

To view, visit change 22344. To unsubscribe, visit settings.