Attention is currently required from: David Hendricks, Angel Pons, Anastasia Klimchuk.

Patch set 6:Code-Review +2

View Change

1 comment:

• Commit Message:

  • Patch Set #5, Line 9:

    strdup return values should be checked for NULL to catch the
    potential error case of out of memory.
    

    First of all, good point about what the patch is doing: indeed, so I updated commit message. […]

    It looks much better. I still would strongly suggest the separate function to complete the work here, which is only a minor step upon this however this patch is more inline with my suggestions.

To view, visit change 70006. To unsubscribe, or for help writing mail filters, visit settings.