Attention is currently required from: Angel Pons, Anastasia Klimchuk.

Nico Huber would like Angel Pons and Anastasia Klimchuk to review this change.

View Change

dummyflasher: Replace another case of `sizeof(struct ...)`

Using the pointer's type instead ensures that we get the right size even
if code changes in the future.

Change-Id: If88ba394095f86c598dcc5cf1751e1c23b132d04
Signed-off-by: Nico Huber <nico.huber@secunet.com>
---
M dummyflasher.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/58/55358/1
diff --git a/dummyflasher.c b/dummyflasher.c
index ba06e7c..eb3789c 100644
--- a/dummyflasher.c
+++ b/dummyflasher.c
@@ -947,7 +947,7 @@
{
struct stat image_stat;

- struct emu_data *data = calloc(1, sizeof(struct emu_data));
+ struct emu_data *data = calloc(1, sizeof(*data));
if (!data) {
msg_perr("Out of memory!\n");
return 1;

To view, visit change 55358. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If88ba394095f86c598dcc5cf1751e1c23b132d04
Gerrit-Change-Number: 55358
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-MessageType: newchange