Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Nikolai Artemiev.
Patch set 63:Code-Review +1
5 comments:
Commit Message:
Patch Set #63, Line 7: spi25_statusreg: delete read_status_register()
Apart from deleting a function, this patch does one more good thing: it propagates error codes (which previously were ignored).
This is very worth mentioning in commit message.
Something like "As a side effect of using spi_read_register() instead of old function, error codes are propagated and not ignored". And this probably goes after the comment below.
Patch Set #63, Line 7: read_status_register
Looking at the code, it is `spi_read_status_register()` function which is deleted :)
Also, it is worth adding one sentence explaining why the function is deleted, something like "The function is no longer needed, since it can be fully replaced by generic spi_read_register()".
Patch Set #63, Line 11: flashrom -{r,w,E}
Same as for previous patch: maybe a bit more info about chips / or environment where this was tested?
File spi25.c:
Maybe I forgot and it was discussed before, but where 500 comes from ? Don't know, but maybe it is worth a comment?
To view, visit change 59529. To unsubscribe, or for help writing mail filters, visit settings.