View Change

2 comments:

• File hwaccess_x86_io_unittest.h:

  • Patch Set #19, Line 32:

    This header needs guards for x86 as it's inclusion will result in attempts by the toolchain to resol […]

    Thank you so much for spotting this! I missed it, sorry for that!
    I created CB:55741 because I am not sure how urgent is this (I understand tests are broken on non-x86). It is not completely tested yet, I wanted to see how it breaks and how it is fixed on arm, sorry it is taking long time for me :\

  • Patch Set #19, Line 41: #include <sys/io.h>

    Inclusion of this header in hwaccess_x86_io. […]

    Thank you so much! I used this in CB:55741 (see also my other reply).

To view, visit change 51487. To unsubscribe, or for help writing mail filters, visit settings.