Attention is currently required from: Anastasia Klimchuk.

Patch set 1:Code-Review +2

View Change

1 comment:

• File libflashrom.c:

  • Patch Set #1, Line 309: static int compare_region_with_dump(const struct romentry *const a, const struct romentry *const b)

    I am wondering whether `read_prot` and `write_prot` should be here. […]

    It should always be zeroed, but that's true because `flashrom_layout_new` uses `calloc` and that doesn't seem like a guarantee the API actually makes- it would be easy to change things to not always zero a layout on creation and introduce a bug if this were to be reading fields that aren't meaningful, so I'm leaning toward not checking those fields.

To view, visit change 85292. To unsubscribe, or for help writing mail filters, visit settings.