Attention is currently required from: Simon Buhrow, Thomas Heijligen, Aarya, Anastasia Klimchuk.
Patch set 21:Code-Review +2
View Change
2 comments:
File flashrom.c:
Patch Set #6, Line 1701: (uint8_t*)
The newcontents buffer may b written while aligning boundaries. […]
OK, but we should fix the `const void *` in another patch.
Patch Set #6, Line 1708: free_erase_layout(erase_layout, erasefn_count);
`free_erase_layout(erase_layout, count_usable_erasers(flashctx));` […]
Ack
To view, visit change 71173. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id79ae943eb9d6a817da28381db477725834faaf6
Gerrit-Change-Number: 71173
Gerrit-PatchSet: 21
Gerrit-Owner: Aarya <aarya.chaumal@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Simon Buhrow
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Simon Buhrow
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Aarya <aarya.chaumal@gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Comment-Date: Thu, 26 Jan 2023 07:46:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Comment-In-Reply-To: Aarya <aarya.chaumal@gmail.com>
Gerrit-MessageType: comment