Attention is currently required from: Nicholas Chin, ZhiYuanNJ.
View Change
1 comment:
File ch347_spi.c:
Patch Set #11, Line 291: speed_index = 1;
But you haven't done? :)
What I meant is that you don't need `int divisor` at all. You can initialise
int speed_index = 2; /* default 15M SPI */
and then always use `spispeeds[speed_index].divisor`
You won't have `int divisor` at all.
To view, visit change 82776. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: If2be48929db540a6598ac0b60b37e64597156db7
Gerrit-Change-Number: 82776
Gerrit-PatchSet: 13
Gerrit-Owner: ZhiYuanNJ
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: ZhiYuanNJ
Gerrit-Attention: Nicholas Chin <nic.c3.14@gmail.com>
Gerrit-Comment-Date: Wed, 21 Aug 2024 03:30:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Comment-In-Reply-To: ZhiYuanNJ