Attention is currently required from: Richard Hughes, Daniel Campello, Angel Pons, Patrick Rudolph.

Patch set 13:Code-Review +1

View Change

5 comments:

• Commit Message:

  • Patch Set #11, Line 15:

    Would you mind having this as a follow up CL?

    Oh sorry for confusion, I didn't mean to write another unit test! I mean test in a literal meaning, build flashrom and run it on a device.
    CLI is now calling libflashrom functions, so calling read-erase-write from command line will execute the code which is added in this patch.

    And then if you can add the info into commit message what test scenarios were run, that would be perfect. Thanks!

• Patchset:

  • Patch Set #13:

    Special thanks for avoiding global state for progress_state!
    Just few comments left.

• File include/libflashrom.h:

  • Patch Set #13, Line 113: flashrom_update_progress_callback

    Should this also be added in libflashrom.map ?

• File libflashrom.c:

  • Patch Set #13, Line 106: @param userdata Userdata pointer to include with the progress callback.

    This param is now called `progress_state`

  • Patch Set #13, Line 98:

    /**
     * @brief Set the progress callback function.
     *
     * Set a callback function which will be invoked whenever libflashrom wants
     * to indicate the progress has changed. This allows frontends to do whatever
     * they see fit with such values, e.g. update a progress bar in a GUI tool.
     *
     * @param progress_callback Pointer to the new progress callback function.
     * @param userdata Userdata pointer to include with the progress callback.
     */
    

    Documentation has been moved to header file in CB:63903 , so you will need to rebase and then move this doc to header file together with the others.

To view, visit change 49643. To unsubscribe, or for help writing mail filters, visit settings.