Nico Huber submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved
print_buildinfo: remove unreachable print of libpci version

The libpci header is neither directly nor indirectly included in
flashrom.c. `PCILIB_VERSION` is therefore never set and the following
print statement is dead code. Since libpci is the only library in
buildinfo, Drop it.

Change-Id: I0b5dbf3bd82a2ffe64b73881383e92f7dad4c382
Signed-off-by: Thomas Heijligen <thomas.heijligen@secunet.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/62833
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
---
M flashrom.c
1 file changed, 0 insertions(+), 7 deletions(-)

diff --git a/flashrom.c b/flashrom.c
index ac61259..51a9fbe 100644
--- a/flashrom.c
+++ b/flashrom.c
@@ -1646,13 +1646,6 @@
void print_buildinfo(void)
{
msg_gdbg("flashrom was built with");
-#if NEED_PCI == 1
-#ifdef PCILIB_VERSION
- msg_gdbg(" libpci %s,", PCILIB_VERSION);
-#else
- msg_gdbg(" unknown PCI library,");
-#endif
-#endif
#ifdef __clang__
msg_gdbg(" LLVM Clang");
#ifdef __clang_version__

4 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.

To view, visit change 62833. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0b5dbf3bd82a2ffe64b73881383e92f7dad4c382
Gerrit-Change-Number: 62833
Gerrit-PatchSet: 6
Gerrit-Owner: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Felix Singer <felixsinger@posteo.net>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-MessageType: merged