>> Reading is faster in many cases now, is this still needed / wanted?
>
> Despite the small memory size (just 128 KB), all the operations
> with KB9012 internal flash through EDI interface are much much
> slower than for the regular flash chips. Sadly it takes 1 hour for
> the complete read/erase/write/read(verify) cycle.

I see. The patch generally looks good. Two things, though:

1. `contents file` sounds ambiguous, how about `reference file`?

2. The manpage needs an update. It should also be noted when the
data from the reference file is used (currently only at the begin-
ning, not later, e.g. when flash content is reread after a failed
erase).

This patch tries
to migitate this problem, it is essential for the comfortable
development of KB9012 free-as-in-freedom firmware replacement

Does "free-as-in-freedom" mean anything to you, or are you only
trying to emphasize that this is important?

View Change

To view, visit change 23263. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf153b6955f37779ae9bfb228a434ed10c304947
Gerrit-Change-Number: 23263
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Fri, 02 Feb 2018 22:29:45 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No