Nico Huber has posted comments on this change. ( https://review.coreboot.org/23263 )
Change subject: [v4,6/6] Add support for reading the current flash contents from a file ......................................................................
Patch Set 1:
Reading is faster in many cases now, is this still needed / wanted?
Despite the small memory size (just 128 KB), all the operations with KB9012 internal flash through EDI interface are much much slower than for the regular flash chips. Sadly it takes 1 hour for the complete read/erase/write/read(verify) cycle.
I see. The patch generally looks good. Two things, though:
1. `contents file` sounds ambiguous, how about `reference file`?
2. The manpage needs an update. It should also be noted when the data from the reference file is used (currently only at the begin- ning, not later, e.g. when flash content is reread after a failed erase).
This patch tries to migitate this problem, it is essential for the comfortable development of KB9012 free-as-in-freedom firmware replacement
Does "free-as-in-freedom" mean anything to you, or are you only trying to emphasize that this is important?