View Change

7 comments:

• File raiden_debug_spi.c:

  • Patch Set #2, Line 391:

    alignment \t \s mixing.

    Ack

  • Patch Set #2, Line 720: int

    This variable should be declared out of the loop, c.f. […]

    Ack

  • Patch Set #2, Line 726:

    Replace 8 spaces with a tab?

    I'm using spaces to align these multi-line function calls, especially the ones with mutli-line strings. They should have the same level of tabbed indentation.

  • Patch Set #2, Line 782: status =

    Sounds good

    Ack

  • Patch Set #2, Line 855: PACKET_ID_V2_RESPONSE_CONTINUE) {

    This fits on a single line, or is it very close to the limit?

    I think it's 79 (w/ 4 tabs) characters, I'll switch it if it's still reasonable.

  • Patch Set #2, Line 913: } else {

    How about "else if" here? […]

    I can add these as function pointers in 'struct raiden_debug_spi_data'.

    These would then follow this template and no chains are needed.

    if (ctx_data->write_command) {
        ctx_data->write_command(ctx_data, &write_ctx, &read_ctx);
    } else {
        /* Raise error */
        msg(...)
    }

    
    The same without the error else state can be done for the restart_response_v2(ctx_data) later on too. If a v3 protocol exists, it just fills in the fields that it uses.

  • Patch Set #2, Line 1063:

    indent has spaces not tab

    Ack

To view, visit change 41533. To unsubscribe, or for help writing mail filters, visit settings.