Thomas Heijligen has uploaded this change for review.

View Change

Makefile: move c compiler check to the top

Cleanup the compiler target by outsourcing the test to an own variable.

This is in preparation for further changes.

Change-Id: I3d6f08ef030744c772b4ec0dc2c9e614fb90461d
Signed-off-by: Thomas Heijligen <thomas.heijligen@secunet.com>
---
M Makefile
A Makefile.d/cc_test.c
M Makefile.include
3 files changed, 14 insertions(+), 15 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/16/58616/1

diff --git a/Makefile b/Makefile
index e8bf8fc..c09e9cf 100644
--- a/Makefile
+++ b/Makefile
@@ -158,6 +158,8 @@
 CC = gcc
 endif
 
+CC_WORKING := $(call c_compile_test, Makefile.d/cc_test.c)
+
 # Determine the destination OS, architecture and endian
 # IMPORTANT: The following lines must be placed before TARGET_OS, ARCH or ENDIAN
 # is ever used (of course), but should come after any lines setting CC because
@@ -889,13 +891,10 @@
 # to environment variables and are referenced with $$<varname> later
 
 compiler: featuresavailable
-	@printf "Checking for a C compiler... " | tee -a $(BUILD_DETAILS_FILE)
-	@echo "$$COMPILER_TEST" > .test.c
-	@printf "\nexec: %s\n" "$(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) .test.c -o .test$(EXEC_SUFFIX)" >>$(BUILD_DETAILS_FILE)
-	@{ { { { { $(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) .test.c -o .test$(EXEC_SUFFIX) >&2 && \
-		echo "found." || { echo "not found."; \
-		rm -f .test.c .test$(EXEC_SUFFIX); exit 1; }; } 2>>$(BUILD_DETAILS_FILE); echo $? >&3 ; } | tee -a $(BUILD_DETAILS_FILE) >&4; } 3>&1;} | { read rc ; exit ${rc}; } } 4>&1
-	@rm -f .test.c .test$(EXEC_SUFFIX)
+	@echo -n "C compiler found: "
+	@if [ $(CC_WORKING) = yes ]; \
+		then echo $$($(CC) --version 2>/dev/null | head -1); \
+		else echo no; echo Aborting.; exit 1; fi
 	@echo Target arch is $(ARCH)
 	@if [ $(ARCH) = unknown ]; then echo Aborting.; exit 1; fi
 	@echo Target OS is $(TARGET_OS)
diff --git a/Makefile.d/cc_test.c b/Makefile.d/cc_test.c
new file mode 100644
index 0000000..69e48e9
--- /dev/null
+++ b/Makefile.d/cc_test.c
@@ -0,0 +1,6 @@
+int main(int argc, char **argv)
+{
+	(void) argc;
+	(void) argv;
+	return 0;
+}
\ No newline at end of file
diff --git a/Makefile.include b/Makefile.include
index ca70d05..2b5a344 100644
--- a/Makefile.include
+++ b/Makefile.include
@@ -36,15 +36,9 @@
 $(strip $(shell $(CC) -E $1 2>/dev/null | tail -1 | tr -d '"'))
 endef
 
-define COMPILER_TEST
-int main(int argc, char **argv)
-{
-	(void) argc;
-	(void) argv;
-	return 0;
-}
+define c_compile_test
+$(shell $(CC) -c -Wall -Werror -o /dev/null $1 2>/dev/null && echo yes || echo no)
 endef
-export COMPILER_TEST
 
 define LIBPCI_TEST
 /* Avoid a failing test due to libpci header symbol shadowing breakage */

To view, visit change 58616. To unsubscribe, or for help writing mail filters, visit settings.