Attention is currently required from: Arthur Heymans, Nico Huber, Jonathan Zhang, Edward O'Callaghan, Angel Pons.
View Change
2 comments:
Patchset:
Patch Set #2:
The current patch also changes when the warning is printed (not anymore
for ISL < 16) while the commit message states otherwise.
Indeed, this is an issue.
Yep, nice catch. Done.
File ich_descriptors.c:
To view, visit change 57633. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2b6301c6cd08f6822340d61a3454b31fddc3be52
Gerrit-Change-Number: 57633
Gerrit-PatchSet: 3
Gerrit-Owner: David Hendricks
Gerrit-Reviewer: Angel Pons <angel.pons@9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur.heymans@9elements.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: David Hendricks <david.hendricks@gmail.com>
Gerrit-Attention: Arthur Heymans <arthur.heymans@9elements.com>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Angel Pons <angel.pons@9elements.com>
Gerrit-Comment-Date: Tue, 14 Sep 2021 18:42:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment