View Change

1 comment:

• File bitbang_spi.c:

  • Patch Set #2, Line 157: bitbang_spi_set_sck(master, 0);

    I didn't mean to change it to further optimize but to correct it. […]

    I did spend some time on the page... but I don't recall studying the timing diagram much. I spent my time trying to decode the bulletted text describing CPHA=0 and CPHA=1 (and wishing there was a real standard to look at).

    Regarding what CPHA=0 means, there's some additional text describing the first bit: "For the first cycle, the first bit must be on the MOSI line before the leading clock edge.". To be honest I suspect this phrasing is a little loose since "before" is not a sufficient timing constraint. I think it should be "a half period before".

    Anyway, the code implements the "half period before" timings so I still haven't seen where it is not correct.

To view, visit change 26946. To unsubscribe, or for help writing mail filters, visit settings.