View Change
2 comments:
File linux_mtd.c:
Patch Set #4, Line 231: perr(
strace showed the fread() working, but I didn't see it try to do the fwrite() after the fseek(). […]
I think I found it, fopen() doesn't know an "rw" mode. I think
what we want is "r+".
File linux_mtd.c:
Patch Set #6, Line 342: rw
There is no "rw". I think what we want is "r+", i.e. open for reading and writing but don't create the file if it doesn't exist.
To view, visit change 25706. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d6bb282863a5cf69909e28a1fc752b35f1b9599
Gerrit-Change-Number: 25706
Gerrit-PatchSet: 6
Gerrit-Owner: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Brian Norris <briannorris@chromium.org>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Tue, 15 May 2018 10:07:38 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No