Attention is currently required from: Anastasia Klimchuk, Matt DeVillier.

View Change

1 comment:

• Patchset:

  • Patch Set #2:

    Adding a couple comments which are probably out-of-scope and non-blocking, though you should check with flashrom's current maintainers:

    • I've run into issues where write-protection capabilities are different with evil twins. So you might want to bail out if a write-protect command is used or add logic to compare write-protect capabilities with chips sharing the same ID.
    • Some chips share an ID but use a different voltage. This is probably fine with internal programmers since the programmer's IO pins and and chip ought to match in this regard, but may pose an issue with external programmers such as Dediprog SF100/SF600/etc.
    • Read, write, and erase opcodes are probably the same unless there's something weird going on with QE or 4BA enable/exit for a particular family of chips. I'm not sure if this is a real issue now, though it might be good to check those modes or feature bits.

To view, visit change 85160. To unsubscribe, or for help writing mail filters, visit settings.