Attention is currently required from: Namyoon Woo, Thomas Heijligen, Edward O'Callaghan.

View Change

2 comments:

• File spi.c:

  • Patch Set #1, Line 133:

    int probe_variable_size(struct flashctx *flash)
    {
    	unsigned int i;
    	const struct emu_data *emu_data = flash->mst->spi.data;
    

    This is not probing anything, right? Just emulating. The name does not indicate the emulation however... I wasn't thinking about it while the function was in dummy, because dummy is all about emulation. But now it is in spi.c.

    Also it relies on emu_data, what happens if there is some other data in the context? another struct type?

    I understand these questions are not about build system, it's just some thoughts triggered by the change.

  • Patch Set #1, Line 138:

    /* Skip the probing if we don't emulate this chip. */
    	if (!emu_data || emu_data->emu_chip != EMULATE_VARIABLE_SIZE)
    		return 0;
    

    Why this branch returns 0? There was no probing done?
    I know it was like this before :) Thinking aloud.

To view, visit change 63831. To unsubscribe, or for help writing mail filters, visit settings.