View Change
1 comment:
File lspcon_i2c_spi.c:
Patch Set #8, Line 364: uint8_t write_buffer[PAGE_SIZE + 1] = { 0 };
put this before the if and you may want to add the code comment I provided before about the prefix of idx 0 needing to be set to zero or at least make careful note of it perhaps a line before the memcpy().
To view, visit change 39687. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I039e683252cfaf1ffef8694a3e8081b1b6b944f7
Gerrit-Change-Number: 39687
Gerrit-PatchSet: 8
Gerrit-Owner: Shiyu Sun <sshiyu@google.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-CC: Sam McNally <sammc@google.com>
Gerrit-Comment-Date: Wed, 01 Apr 2020 06:04:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment