Attention is currently required from: Subrata Banik, Nico Huber, Angel Pons.

View Change

1 comment:

• File ichspi.c:

  • Patch Set #4, Line 508: FDBC

    `HSFC_FDBC_MASK` exists but there is no macro to resolve this symbol `HSFC_FDBC_MASK_OFF`

    So, just very straightforward thought: if you also rename HSFC_FDBC_OFF into HSFC_FDBC_MASK_OFF then naming complies with existing pprint_reg() design? and there will be no need for _pprint_reg() ?

    Not sure whether this straightforward idea is the most correct.

    It seems like a good idea to have only one print macro: then there is no question which one to use, and how to use. But I am not sure how much work it is.

    I can see that renaming HSFC_FDBC -> HSFC_FDBC_MASK plays a role further in the chain in CB:62892 so "do nothing" is not an option as it blocks further work. That's why I thought, if getting rid of _pprint_reg() is too much (for whatever reason) then maybe renaming both HSFC_FDBC -> HSFC_FDBC_MASK and HSFC_FDBC_OFF -> HSFC_FDBC_MASK_OFF can be okay?
    And it can be a temp step on the way to getting rid of _pprint_reg() later.

To view, visit change 62894. To unsubscribe, or for help writing mail filters, visit settings.