Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk.

View Change

6 comments:

• File dummyflasher.c:

  • Patch Set #10, Line 63: bool wp; /* state of hardware write protection */

    And this name also can be hwwp

    Done

  • Patch Set #10, Line 244: write_flash_part

    The name is a bit confusing, what "part" means here? And same for erase_flash_part

    Part of the emulated flash defined by the range. Changed to "data".

  • Patch Set #10, Line 264: /* XXX: should data->erase_to_zero be taken into account here? */

    Is it a TODO, or work-in-progress note?

    It's a question to anyone who'll read the code. It just looks like a bug, but I'm not entirely sure.

  • Patch Set #10, Line 967: will have WP enabled

    Hardware WP?

    Done

• File flashrom.8.tmpl:

  • Patch Set #10, Line 696: Winbond " W25Q128FV " SPI flash chip (16384 kB, RDID)"

    Oh wow this was missing in the man for all the time?! Thank you for spotting! […]

    Sent in CB:59811

  • Patch Set #10, Line 792: wp=state

    I remember we discussed that in the patch with test, yes now I see that "hwwp" would be a better nam […]

    Done

To view, visit change 59074. To unsubscribe, or for help writing mail filters, visit settings.