Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen.
Patch set 5:Code-Review +2
View Change
1 comment:
Patchset:
Patch Set #4:
Just a thought regarding the commit message hook. […]
From the point of view of the readers of guidelines, I think it is more convenient to have a clear command in the guidelines.
However, looks like we should update both, because command that is currently shown in here https://review.coreboot.org/admin/repos/flashrom,general is that command which not working.
I would really prefer to update both places, does this sound good to you? So we will do both ways at the same time.
To view, visit change 68647. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib83568c7ff149a8ec34ad7e92720c36a89def7bd
Gerrit-Change-Number: 68647
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Comment-Date: Fri, 04 Nov 2022 06:27:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Singer <felixsinger@posteo.net>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-MessageType: comment