Attention is currently required from: Nico Huber, Subrata Banik, Thomas Heijligen, Edward O'Callaghan.

Patch set 3:Code-Review +1

View Change

1 comment:

• File ich_descriptors.c:

  • Patch Set #3, Line 167: static int get_density(enum ich_chipset cs, const struct ich_descriptors *desc, uint8_t idx, uint8_t *size_enc, uint8_t *size_max)

    Can you provide information about the meaning of the return values?

    The idea is great, thanks for the patch!

    I agree with Thomas, it would be good to have clear description of what are possible return values, and what each of them mean. Especially because `get_density()` is now called in two different contexts, and each of the contexts is treating return values differently.
    For example, one of the callers treats -2 and -1 differently, the other caller doesn't care.

To view, visit change 63321. To unsubscribe, or for help writing mail filters, visit settings.