View Change

4 comments:

• File nicintel_eeprom.c:

  • Patch Set #1, Line 103: {PCI_VENDOR_ID_INTEL, 0x1522, NT, "Intel", "I350 Gigabit Network Connection External SGMII PHY"},

    Done

    Done

  • Patch Set #1, Line 109: switch (device_id)

    Done

    Done

  • Patch Set #1, Line 477: uintptr_t io_base_addr = pcidev_readbar(dev, PCI_BASE_ADDRESS_0);

    Well, there may be many more instances of uint32_t to store addresses, so it would be a good idea to […]

    Ack

• File nicintel_spi.c:

  • Patch Set #1, Line 277: (dev->device_id & 0xfff0) == 0x1510

    Done

    Done

To view, visit change 39963. To unsubscribe, or for help writing mail filters, visit settings.