It seems a little weird to have the bulk of the implementation of fmap-from-rom here while only adding the CLI option in the next patch. Maybe it's a good idea to squash both?

View Change

6 comments:

• Commit Message:

  • Patch Set #16, Line 7: Add support to get layout from fmap (e.g. coreboot rom)

    Needs to be updated to mention fmap from rom functionality implementation.

• File fmap.h:

  • Patch Set #16, Line 1: #include <inttypes.h>

    Probably needs license from cbfstool here

• File fmap.c:

  • Patch Set #16, Line 1: #include <ctype.h>

    probably needs licence from cbfstool.

• File layout.c:

  • Patch Set #16, Line 22: #include <sys/stat.h>

    Added headers not needed anymore?

  • Patch Set #16, Line 104:

    accidental newline?

• File libflashrom.c:

  • Patch Set #16, Line 462: offset

    On Intel targets you probably only want and in some reasons even only can, if for instance ME region is not readable, look into the BIOS region. This again will need lsearch in some cases.

    Maybe the start offset and the end of this loop could be made function arguments?

To view, visit change 23203. To unsubscribe, or for help writing mail filters, visit settings.